Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: license #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update: license #143

wants to merge 3 commits into from

Conversation

NikitaMelanin
Copy link

@NikitaMelanin NikitaMelanin commented Jul 18, 2022 •
edited
Loading

update license

joeflack4
joeflack4 reviewed Jul 18, 2022
View reviewed changes
README.md
@@ -3,8 +3,18 @@
![main workflow](https://github.com/cancerDHC/ccdh-terminology-service/actions/workflows/main.yml/badge.svg)

The CCDH terminology service is a RESTful API that supports the validation, lookup, binding, and mapping of the concepts
in the CCDH data harmonization process and the transformation and validation workflow.
in the CCDH data harmonization process and the transformation and validation workflow.
# License:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably will move this to a LICENSE file.

README.md
in the CCDH data harmonization process and the transformation and validation workflow.
in the CCDH data harmonization process and the transformation and validation workflow.
# License:
BSD License
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually pick MIT, but I'm not super picky. Any rationale for BSD over other licenses?

@joeflack4
Copy link
Collaborator

Hey @NikitaMelanin . Thanks for your pull request. Just curious, why ccdh-terminology-service in particular? Do you have a biomedical informatics background / continuing education?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeflack4 joeflack4 joeflack4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaMelanin @joeflack4